Fix shenv

dotfiles/shenv

@@ -22,33 +22,36 @@ if [ "$TERM" = "xterm" ] && [ "$COLORTERM" = "gnome-terminal" ] ; then
   export TERM="xterm-256color"
 fi
 
-# Terminal preferences for i3
-if [ -z "${TERMINAL}" ] ; then
-  for t in urxvt gnome-terminal; do
-    if TERMINAL=$(command -v ${t}) ; then
-      export TERMINAL
-    fi
-  done
-fi
-
-# Browser preferences
-if [ -z "${BROWSER}" ] ; then
-  for t in google-chrome-beta google-chrome firefox ; do
-    if BROWSER=$(command -v ${t}); then
-      export BROWSER
-      break
-    fi
-  done
-fi
-
 # For virtualenvwrapper
 export WORKON_HOME="$HOME/.virtualenvs"
 
 # GPG full key id
 export GPG_ID=7FD58D9A196DCEEEAD671F94F4D7A7915DEA789B
 
-# Setup locale
-if test -x /usr/bin/locale ; then
+# things we need in all interactive shells
+case "$-" in
+  *i*)
+    # Terminal preferences for i3
+    if [ -z "${TERMINAL}" ] ; then
+      for t in urxvt gnome-terminal; do
+        if TERMINAL=$(command -v ${t}) ; then
+          export TERMINAL
+        fi
+      done
+    fi
+
+    # Browser preferences
+    if [ -z "${BROWSER}" ] ; then
+      for t in google-chrome-beta google-chrome firefox ; do
+        if BROWSER=$(command -v ${t}); then
+          export BROWSER
+          break
+        fi
+      done
+    fi
+
+    # Setup locale
+    if test -x /usr/bin/locale ; then
       for l in en_US.utf8 en_US.UTF-8 C.UTF-8 C.utf8 C ; do
         if /usr/bin/locale -a | grep -q "${l}" ; then
           export LC_CTYPE=${l}
@@ -65,7 +68,7 @@ if test -x /usr/bin/locale ; then
           break
         fi
       done
-else
+    else
       export LC_CTYPE=C
       export LC_NUMERIC=C
       export LC_TIME=C
@@ -77,8 +80,11 @@ else
       export LC_TELEPHONE=C
       export LC_MEASUREMENT=C
       export LC_IDENTIFICATION=C
-fi
-export LC_COLLATE=C
+    fi
+    export LC_COLLATE=C
+    ;;
+esac
+
 
 # Opt out of .net telemetry
 export DOTNET_CLI_TELEMETRY_OPTOUT=1